wonook commented on a change in pull request #187: [NEMO-324] Distinguish
Beam's run and waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r395438787
##########
File path: client/src/main/java/org/apache/nemo/client/JobLauncher.java
##########
@@ -261,7 +264,7 @@ public static void launchDAG(final IRDAG dag,
final Map<Serializable, Object>
broadcastVariables,
final String jobId) {
// launch driver if it hasn't been already
- if (driverReadyLatch == null) {
+ if (driverReadyLatch == null || jobDoneLatch == null) {
Review comment:
This statement simply checks whether the `setup` method has been called or
not, and calls it if it haven't. The driverReadyLatch has to be there to wait
for the driver to be ready later on in the code. Do you think that it would be
better to create another `boolean` variable to indicate whether the `setup`
method has been called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
