taegeonum commented on a change in pull request #187: [NEMO-324] Distinguish
Beam's run and waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r395373641
##########
File path: client/src/main/java/org/apache/nemo/client/JobLauncher.java
##########
@@ -261,7 +264,7 @@ public static void launchDAG(final IRDAG dag,
final Map<Serializable, Object>
broadcastVariables,
final String jobId) {
// launch driver if it hasn't been already
- if (driverReadyLatch == null) {
+ if (driverReadyLatch == null || jobDoneLatch == null) {
Review comment:
This code is hard to understand. Isn't there a variable for the driver
status? and can't we use the variable for checking the driver status? instead
of checking `null` and `getCount() > 0`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
