matthiasblaesing commented on a change in pull request #494: Adding
LICENSE/NOTICE/DISCLAIMER to NBMs, packing OSGi jars into NBMs…
URL: https://github.com/apache/incubator-netbeans/pull/494#discussion_r181554010
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java
##########
@@ -581,25 +594,32 @@ public void execute () throws BuildException {
overrideLicenseIfNeeded() ;
- moduleAttributes = new ArrayList<> ();
+ Map<String, Supplier<Document>> moduleAttributes = new
LinkedHashMap<>();
File module = new File( productDir, moduleName );
Attributes attr = getModuleAttributesForLocale("");
if (attr == null) {
- // #181025: OSGi bundle, copy unmodified.
- Copy copy = new Copy();
- copy.setProject(getProject());
- copy.setOwningTarget(getOwningTarget());
- copy.setFile(module);
- copy.setTofile(new
File(nbm.getAbsolutePath().replaceFirst("[.]nbm$", ".jar")));
- copy.execute();
- // XXX possibly sign it
- // XXX could try to run pack200, though not if it was signed
- return;
+ System.err.println("attr=" + attr);
+ System.err.println("alwaysCreateNBM=" + alwaysCreateNBM);
Review comment:
Please remove the `System.err` calls - I understand why they are there, but
I think they should not be in the final commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
