eirikbakke commented on a change in pull request #1846: [NETBEANS-3428]
FlatLaf: fixes for form designer
URL: https://github.com/apache/netbeans/pull/1846#discussion_r363102357
##########
File path:
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLFCustoms.java
##########
@@ -63,6 +67,12 @@
"nb.multitabs.button.left.icon",
FlatTabControlIcon.get(TabControlButton.ID_SCROLL_LEFT_BUTTON), // NOI18N
"nb.multitabs.button.right.icon",
FlatTabControlIcon.get(TabControlButton.ID_SCROLL_RIGHT_BUTTON), // NOI18N
"nb.multitabs.button.rollover", true, // NOI18N
+
+ // Change some colors from ColorUIResource to Color because they
are used as
+ // background colors for checkboxes (e.g. in
org.netbeans.modules.palette.ui.CategoryButton),
+ // which in FlatLaf paint background only if background color is
not a UIResource.
+ "PropSheet.setBackground", new
Color(UIManager.getColor("PropSheet.setBackground").getRGB()),
+ "PropSheet.selectedSetBackground", new
Color(UIManager.getColor("PropSheet.selectedSetBackground").getRGB()),
Review comment:
Am I right that these changes (in FlatLFCustoms) are related to the LAF's
appearance as a whole, i.e. not specifically related to the form designer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
