eirikbakke commented on a change in pull request #1846: [NETBEANS-3428]
FlatLaf: fixes for form designer
URL: https://github.com/apache/netbeans/pull/1846#discussion_r363114296
##########
File path: java/form/src/org/netbeans/modules/form/FormLoaderSettings.java
##########
@@ -472,12 +472,13 @@ public void setPaletteInToolBar(boolean value) {
* @return background color of the designer.
*/
public java.awt.Color getFormDesignerBackgroundColor() {
- Color defaultBackground = UIManager.getColor( "Tree.background" );
//NOI18N
- if( null == defaultBackground )
+ Color defaultBackground =
UIManager.getColor("nb.formdesigner.designer.background"); //NOI18N
+ if (defaultBackground == null)
+ defaultBackground = UIManager.getColor("Tree.background"); //NOI18N
+ if (defaultBackground == null)
Review comment:
Oh, right, the constant is from the LAF. My main concern was that it would
seem logical to take it from the JPanel background, rather than invent a new
constant. But since the existing code doesn't do that, I suppose it makes sense
to add a constant to preserve backwards-compatibility.
How come Tree.background is not dark for FlatLAF, though?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
