eirikbakke commented on a change in pull request #1846: [NETBEANS-3428]
FlatLaf: fixes for form designer
URL: https://github.com/apache/netbeans/pull/1846#discussion_r363102032
##########
File path: java/form/src/org/netbeans/modules/form/FormLoaderSettings.java
##########
@@ -497,9 +498,11 @@ public void setFormDesignerBackgroundColor(java.awt.Color
value) {
* @return color of the border of the designer.
*/
public java.awt.Color getFormDesignerBorderColor() {
- int rgb = getPreferences().getInt(PROP_FORMDESIGNER_BORDER_COLOR , new
Color(224, 224, 255).getRGB());
+ Color defaultBackground =
UIManager.getColor("nb.formdesigner.designer.borderColor"); //NOI18N
Review comment:
Isn't this what the PROP_FORMDESIGNER_BORDER_COLOR property is for? Or does
that have some other purpose?
Also, shouldn't this come from whichever LAF is being used to display form
designer components? (As in my previous comment.)
Also, why is the new property using the word "designer" twice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
