DevCharly commented on a change in pull request #1846: [NETBEANS-3428] FlatLaf:
fixes for form designer
URL: https://github.com/apache/netbeans/pull/1846#discussion_r363389727
##########
File path: java/form/src/org/netbeans/modules/form/FormLoaderSettings.java
##########
@@ -497,9 +498,11 @@ public void setFormDesignerBackgroundColor(java.awt.Color
value) {
* @return color of the border of the designer.
*/
public java.awt.Color getFormDesignerBorderColor() {
- int rgb = getPreferences().getInt(PROP_FORMDESIGNER_BORDER_COLOR , new
Color(224, 224, 255).getRGB());
+ Color defaultBackground =
UIManager.getColor("nb.formdesigner.designer.borderColor"); //NOI18N
Review comment:
> Is there a reason why these were not needed to implement the other LAFs
(e.g. Darcula, GTK, Aqua, Windows)?
Because the default values work for light themes. But look not so good for
dark themes. Here are screenshots of Darcula and Dark Metal. The design border
(red arrow) is way too light:
> Also, is there a convention of putting constants at the end of
org.netbeans.swing.plaf.LFCustoms for every key in used in UIDefaults?
Don't know. Most of them can only be used in subclasses because they are
protected. In case of FlatLaf, the values are in the properties files and
constants are not used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
