JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491978666
##########
File path: ide/projectapi/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi/1
-OpenIDE-Module-Specification-Version: 1.77
+OpenIDE-Module-Specification-Version: 1.78
OpenIDE-Module-Localizing-Bundle:
org/netbeans/modules/projectapi/Bundle.properties
OpenIDE-Module-Layer: org/netbeans/modules/projectapi/layer.xml
-OpenIDE-Module-Recommends: cnb.org.netbeans.modules.projectapi.nb
+OpenIDE-Module-Needs: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
@tzezula: Here we need an implementation of
`org.netbeans.spi.project.ProjectManagerImplementation`. Previously the module
recommended single implementation, but that wasn't enough. If the module was
missing a `NullPointerException` was raised. Hence we "need" - e.g. the module
isn't going to be enabled without an implementation, but the implementation can
come from any module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
