tzezula commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r492891025
##########
File path: ide/projectapi/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi/1
-OpenIDE-Module-Specification-Version: 1.77
+OpenIDE-Module-Specification-Version: 1.78
OpenIDE-Module-Localizing-Bundle:
org/netbeans/modules/projectapi/Bundle.properties
OpenIDE-Module-Layer: org/netbeans/modules/projectapi/layer.xml
-OpenIDE-Module-Recommends: cnb.org.netbeans.modules.projectapi.nb
+OpenIDE-Module-Needs: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
Makes sense.
##########
File path:
ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java
##########
@@ -441,12 +441,18 @@ boolean closeBeforeOpen(final Project[] arr) {
}
});
}
-
+
+ @NbBundle.Messages({
+ "LOAD_PROJECTS_ON_START=true"
+ })
private void loadOnBackground() {
- lazilyOpenedProjects = new ArrayList<Project>();
- List<URL> URLs =
OpenProjectListSettings.getInstance().getOpenProjectsURLs();
- final List<Project> initial = new ArrayList<Project>();
- final LinkedList<Project> projects = URLs2Projects(URLs);
+ lazilyOpenedProjects = new ArrayList<>();
+ final boolean loadProjectsOnStart =
"true".equals(Bundle.LOAD_PROJECTS_ON_START());
Review comment:
It's an interesting usage of resource bundle. :-)
But I think it's rather a hack to use module resource bundle for
configuration.
Do we already use such a pattern somewhere?
If not I would prefer a method.
##########
File path: ide/projectapi.nb/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi.nb
OpenIDE-Module-Localizing-Bundle:
org/netbeans/modules/projectapi/nb/Bundle.properties
-OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb
-OpenIDE-Module-Specification-Version: 1.13
+OpenIDE-Module-Provides: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
