JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491975367
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/AutoUpdateCatalogParser.java
##########
@@ -240,6 +241,8 @@ public void endElement (String uri, String localName,
String qName) throws SAXEx
break;
case manifest :
break;
+ case message_digest:
Review comment:
The `AutoUpdate` task was very verbose with modern catalogs. Assuming
this field got in with one of @matthiasblaesing fixes, I've added it to the
set of recognized, but not processed fields.
##########
File path:
platform/settings/src/org/netbeans/modules/settings/RecognizeInstanceObjects.java
##########
@@ -93,24 +94,49 @@ protected Lookup lookupFor(Object obj) {
return null;
}
- private static final class OverObjects extends ProxyLookup
- implements PropertyChangeListener, FileChangeListener {
- private final String path;
-
- public OverObjects(String path) {
- super(delegates(null, path));
- this.path = path;
+ private static final class MSL implements PropertyChangeListener {
+ private final PropertyChangeSupport pcs = new
PropertyChangeSupport(this);
+ public static final MSL DEFAULT = new MSL();
+ static {
try {
ModuleSystem ms = Main.getModuleSystem(false);
if (ms != null) {
ModuleManager man = ms.getManager();
-
man.addPropertyChangeListener(WeakListeners.propertyChange(this, man));
+
man.addPropertyChangeListener(WeakListeners.propertyChange(DEFAULT, man));
} else {
LOG.log(Level.WARNING, "Not listening on module system");
Review comment:
This message was printed out everytime new instance of `OverObjects`
was created in a unit test. Quite annoying. Enough to warning once per test.
##########
File path:
java/maven/src/org/netbeans/modules/maven/spi/actions/AbstractMavenActionsProvider.java
##########
@@ -88,6 +88,10 @@ public AbstractMavenActionsProvider() {
files.add(method.getFile());
}
+ if (files.isEmpty()) {
Review comment:
Ant projects honor `FileObject` as a selection in the `Lookup`, but
Maven projects didn't. After this change they will use `FileObject` (if no
`DataObject` is found) as the indentification of main file to execute.
##########
File path: ide/projectapi.nb/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi.nb
OpenIDE-Module-Localizing-Bundle:
org/netbeans/modules/projectapi/nb/Bundle.properties
-OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb
-OpenIDE-Module-Specification-Version: 1.13
+OpenIDE-Module-Provides: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
@tzezula, there is no need to `OpenIDE-Module-Provides:
cnb.org.netbeans.modules.projectapi.nb` it is provided automatically. Rather
than that the module no provides implementation of
`org.netbeans.spi.project.ProjectManagerImplementation`.
##########
File path: ide/projectapi/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi/1
-OpenIDE-Module-Specification-Version: 1.77
+OpenIDE-Module-Specification-Version: 1.78
OpenIDE-Module-Localizing-Bundle:
org/netbeans/modules/projectapi/Bundle.properties
OpenIDE-Module-Layer: org/netbeans/modules/projectapi/layer.xml
-OpenIDE-Module-Recommends: cnb.org.netbeans.modules.projectapi.nb
+OpenIDE-Module-Needs: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
@tzezula: Here we need an implementation of
`org.netbeans.spi.project.ProjectManagerImplementation`. Previously the module
recommended single implementation, but that wasn't enough. If the module was
missing a `NullPointerException` was raised. Hence we "need" - e.g. the module
isn't going to be enabled without an implementation, but the implementation can
come from any module.
##########
File path: ide/web.browser.api/manifest.mf
##########
@@ -2,5 +2,5 @@ Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.web.browser.api
OpenIDE-Module-Layer: org/netbeans/modules/web/browser/ui/resources/layer.xml
OpenIDE-Module-Localizing-Bundle:
org/netbeans/modules/web/browser/api/Bundle.properties
-OpenIDE-Module-Requires: org.openide.windows.WindowManager
+OpenIDE-Module-Recommends: org.openide.windows.WindowManager
Review comment:
This module can run without window manager. Hence just "recommends".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
