matthiasblaesing commented on pull request #3190: URL: https://github.com/apache/netbeans/pull/3190#issuecomment-930297966
I did not start the discussion about JARs, ZIPs and other containers. I just think, that if we can work around the discussion in a sane way, we should do it. For the formalities I think license headers should be added to: - pom.properties - maven-metadata-local.xml - _remote.repositories Yes I understand, that the files are generated, but it should be trivial to add the headers and add less exceptions. For the generation at runtime comment: Looking at other locations in the `ClassPathImplTest` (and other tests) I was under the impression, that it is common to generate XML in Java code and use it in tests. I'm ok with the exploded JAR approach taken here, I just want to point out, that I did not invent "XML code generation with Java". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
