matthiasblaesing commented on pull request #3190: URL: https://github.com/apache/netbeans/pull/3190#issuecomment-931386683
There are tons of generated code in the unittests - from my POV having explicit test data is more an exception than the norm. Another aspect: JARs can become unmaintainable. The NBMs (essentially JARs under a different name) in the autoupdate.service module are pack200 compressed. There is a realistic chance, that in a few months many people will not be able to work with these files and thus can't check them. If the files are generated at build time, we at least get the error early. I think the exploded JAR and/or the generated at runtime approach both work. Two final statements: - I did not ask for work I was not willing to do! - I do not insist on this, if no one wants the work, fine, then I'll delete the branch and remove #3162. BUT! Then make the useless discussion stop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
