sdedic commented on pull request #3190: URL: https://github.com/apache/netbeans/pull/3190#issuecomment-931556034
Well, I see the effort as partially valid and - more importantly - I want to get the **functional** changes in this PR into `master`. As for JARs, if it is the _contents_ of them what's the subject of the test, then keeping the exploded content in Git is good - changes are well tracked. That's why I've adapted this PR to https://github.com/apache/netbeans/pull/3162 Note: I had to change `MANIFEST.MF` line endings to LF, which is required by `nbbuild/travis/check_line_endings.sh` ... but that's wrong for MANIFEST.MF format - it must use CRLF. This is a price for keeping jar exploded.... the MANIFEST parsing is ikely broken; but it works for these specific tests. If anyone objects against the current PR state (the exploded Jars), please say so - I'll separate the PR into two to get the functional part to the `master` soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
