eirikbakke commented on pull request #3115: URL: https://github.com/apache/netbeans/pull/3115#issuecomment-981813195
I hadn't heard your objection about gradients before! There's a reason for the gradients that I hadn't explained before. The problem is to make the relationship between the tab and the editor visually clear, as well as clearly showing which tab is selected. Having mocked up various different styles, I came to a couple of conflusions: 1) The background color of the bottom of the tab card needs to connect with the background color of the pane below (as mentioned before). And... 2) The background color of the selected tab needs to be brighter than the unselected tabs. The problem is that the editor toolbar is the same brightness as the unselected tab background color. Changing the background colors of the editor toolbar or the draggable spaces between the TopComponents did not look good, in part because there are three levels of surfaces involved (application toolbar and unselected tab area, the editor toolbar, and the editor). The solution was to put a gradient on the selected tab, so the top could be made brighter and the tab would stand out. As for the borders, these are actually _more_ consistent with the rest of the window than the previous style, because there are already borders around each TopComponent. If there are borders around each TopComponent, having them continue around the tab card looks good:  If we really wanted to get rid of borders, we'd need to remove them from the space between the TopComponents as well. (See the Unity screenshot for an example of that. Visual Studio 2022, on the other hand, keeps the borders.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
