mbien commented on code in PR #4013:
URL: https://github.com/apache/netbeans/pull/4013#discussion_r860987690
##########
nbbuild/default.xml:
##########
@@ -246,6 +246,7 @@
</filterchain>
</loadfile>
<property name="metabuild.jms-flags"
value="${jms-base.flags}${jms-desktop.flags}${jms-compiler.flags}${jms-tools.flags}"/>
- <property name="metabuild.jms-flags.jvm"
value="${jms-base.flags.jvm}${jms-desktop.flags.jvm}${jms-compiler.flags.jvm}${jms-tools.flags.jvm}"/>
+ <!-- Excluding jms-tools.flags, as nbjavac usually overlaps with tools
dependencies -->
+ <property name="metabuild.jms-flags.jvm"
value="${jms-base.flags.jvm}${jms-desktop.flags.jvm}${jms-compiler.flags.jvm}"/>
Review Comment:
@sdedic the problem is that `metabuild.jms-flags.jvm` will be pasted into
maven templates too in future, while the other property with `-J` is pasted to
the conf.
example:
https://github.com/apache/netbeans-mavenutils-archetype-nbm-archetype/pull/9
Do we need a third property only for testing? Originally, there was only
supposed to be one property, the only reason there are two is the `-J` prefix -
this already is a fairly ugly workaround IMO.
one for CI, one for nb.conf, one for maven run config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
