mbien commented on code in PR #4013:
URL: https://github.com/apache/netbeans/pull/4013#discussion_r862028029
##########
nbbuild/default.xml:
##########
@@ -246,6 +246,7 @@
</filterchain>
</loadfile>
<property name="metabuild.jms-flags"
value="${jms-base.flags}${jms-desktop.flags}${jms-compiler.flags}${jms-tools.flags}"/>
- <property name="metabuild.jms-flags.jvm"
value="${jms-base.flags.jvm}${jms-desktop.flags.jvm}${jms-compiler.flags.jvm}${jms-tools.flags.jvm}"/>
+ <!-- Excluding jms-tools.flags, as nbjavac usually overlaps with tools
dependencies -->
+ <property name="metabuild.jms-flags.jvm"
value="${jms-base.flags.jvm}${jms-desktop.flags.jvm}${jms-compiler.flags.jvm}"/>
Review Comment:
@sdedic it is intended to be used as an initial set of flags which allow
users to press play on a newly created platform project and it is going to work
even if they added a few features. Users can then optimize the list and only
include what is actually required to run their application.
If surefire will need a different set of flags than the exec plugin... well
that complicates things even further. I hoped we could use one big list for
everything - as initial default. How is the user supposed to know what to
remove for the surefire plugin list?
I guess we could setup two lists by subtracting a few items from the first
list? Maybe we could add the -J just before text substitution so that we don't
need a third list.
as mentioned in the readme
(https://github.com/apache/netbeans/blob/master/nbbuild/jms-config/README).
"There should be hopefully fewer flags over time, devs are encouraged to shrink
the list if possible."
I hope the list won't grow at least :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
