mbien commented on code in PR #4013:
URL: https://github.com/apache/netbeans/pull/4013#discussion_r862094674
##########
nbbuild/default.xml:
##########
@@ -246,6 +246,7 @@
</filterchain>
</loadfile>
<property name="metabuild.jms-flags"
value="${jms-base.flags}${jms-desktop.flags}${jms-compiler.flags}${jms-tools.flags}"/>
- <property name="metabuild.jms-flags.jvm"
value="${jms-base.flags.jvm}${jms-desktop.flags.jvm}${jms-compiler.flags.jvm}${jms-tools.flags.jvm}"/>
+ <!-- Excluding jms-tools.flags, as nbjavac usually overlaps with tools
dependencies -->
+ <property name="metabuild.jms-flags.jvm"
value="${jms-base.flags.jvm}${jms-desktop.flags.jvm}${jms-compiler.flags.jvm}"/>
Review Comment:
sounds like we need another list for tests which use `--limit-modules`, or
as mentioned, it might be possible to simply remove `jdk.shell` flags from the
list before use in tests, assuming its the only special case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
