eirikbakke opened a new pull request, #4335: URL: https://github.com/apache/netbeans/pull/4335
This PR is a follow-up to https://github.com/apache/netbeans/pull/4286 , adding visual improvements and new configuration options for FlatLAF. Before/after screenshots (open in separate tabs at 1:1 device pixel scaling to see details): ### FlatLAF Dark   ### FlatLAF Light   ### Annotated changes  This PR (along with [Neil's PR earlier today](https://github.com/apache/netbeans/pull/4286)) replaces https://github.com/apache/netbeans/pull/3115 , except for the improvements relating to vertical alignment of tab labels, which I will put into a separate PR later. Much of the code here is adapted from improvements that were first merged into the [Windows LAF](https://github.com/apache/netbeans/pull/2967). Visual improvements, annotated in the screenshot above: 1) Align and connect borders between tabs and the container panel below, including on fractional HiDPI scalings (e.g. 150%). Some visual artifacts still exist, e.g. on 125% scaling, but they are less common, and not very visible. 2) Remove an unnecessary border around the editor area. 3) Make sure the "X" in editor tabs are closer to the label than to the separator line. 4) Add some top/bottom margin in the toolbar 5) On FlatLAF Dark, make the tab background color connect with the background of the Project/Files/Services and Navigator panes. 6) Slightly decrease the height of regular tab components (only by two pixels this time). Other visual improvements: * On FlatLAF Dark and Light, make the tab hover effect more subtle. Avoid showing a hover effect on the already-selected tab. Use the blueish active tab area background as a base for this color, rather than plain gray. * Fix positioning of "spinner" icon in sidebar tabs (see [illustration](https://user-images.githubusercontent.com/886243/118890136-2cd61980-b8cc-11eb-8cf7-4cae4acf2b6b.png) in [PR 2967](https://github.com/apache/netbeans/pull/2967), which did the same on the Windows LAF). * Properly clip editor tab borders when tab is partially invisible due to tab scrolling. New configuration settings for FlatLAF.properties * EditorTab.selectedBackgroundBottomGradient (Not used in the current theme, but was tested.) * Add ViewTab/EditorTab.unscaledBorders (Not used in the current FlatLAF theme, but is used in the Windows LAF.) * EditorTab/ViewTab.unselectedHoverBackground/unselectedHoverForeground (Tweaks in these commits make use of unselectedHoverBackground.) * ViewTab/EditorTab.showSelectedTabBorder (Used to explicitly enable borders around the selected tab.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
