eirikbakke commented on code in PR #4335: URL: https://github.com/apache/netbeans/pull/4335#discussion_r914912540
########## platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatDarkLaf.properties: ########## @@ -36,7 +40,9 @@ EditorTab.activeBackground=shade($TabbedPane.underlineColor,75%) EditorTab.activeForeground=darken(@foreground,10%) EditorTab.selectedBackground=@background EditorTab.selectedForeground=@foreground -EditorTab.hoverBackground=lighten(@componentBackground,5%) +# Add the hover effect only for unselected tabs. +EditorTab.hoverBackground=$EditorTab.selectedBackground +EditorTab.unselectedHoverBackground=lighten($EditorTab.activeBackground,7%) Review Comment: Sure, I can make it selectedHoverBackground instead (along with the existing hoverBackground). ########## platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatDarkLaf.properties: ########## @@ -52,6 +58,8 @@ ViewTab.activeBackground=$EditorTab.activeBackground ViewTab.activeForeground=$EditorTab.activeForeground ViewTab.selectedBackground=$EditorTab.selectedBackground ViewTab.selectedForeground=$EditorTab.selectedForeground +ViewTab.hoverBackground=$ViewTab.selectedBackground +ViewTab.unselectedHoverBackground=lighten($ViewTab.activeBackground,7%) Review Comment: Yup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
