eirikbakke commented on code in PR #4335:
URL: https://github.com/apache/netbeans/pull/4335#discussion_r914913961
##########
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatEditorTabCellRenderer.java:
##########
@@ -66,14 +67,27 @@ public class FlatEditorTabCellRenderer extends
AbstractTabCellRenderer {
private static final boolean underlineAtTop =
UIManager.getBoolean("EditorTab.underlineAtTop"); // NOI18N
private static boolean showTabSeparators =
UIManager.getBoolean("EditorTab.showTabSeparators"); // NOI18N
- private static final FlatTabPainter painter = new FlatTabPainter();
+ /**
+ * Margin on the right of the close button. Note that {@code
tabInsets.right} denotes the space
+ * between the caption text and the "close" icon. Here, we set the right
margin to the same
+ * value as the left margin (before the tab's caption).
+ */
+ private static final int CLOSE_ICON_RIGHT_PAD = tabInsets.left;
+
+ private static final boolean showSelectedTabBorder =
Utils.getUIBoolean("EditorTab.showSelectedTabBorder", false); // NOI18N
Review Comment:
Sure, will leave the property there but default to underlineAtTop as
suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
