mbien commented on PR #4431: URL: https://github.com/apache/netbeans/pull/4431#issuecomment-1264488347
> > if a workflow is manually triggered via workflow_dispatch it can't access the pr-context since there is none, > > Does re-run all jobs not work after relabelling then? unfortunately not, that would have been perfect. The workflow takes a snapshot of the context at the beginning it seems. It doesn't see label updates on restarts. > > > we could let unlabeled PRs run everything instead of the minimum job count, (ci:all-tests equivalent) would this be a better default? > > Maybe we should start with that as default anyway, but stated as time-limited for a while as people get used to it / feed back concerns? I had the same thought too. Let me put all-tests as default. Makes the transition easier > > Either way, make sure to do a mail on dev@ with `[NOTICE]` in the subject when this merges. Then no-one should be complaining they didn't see it! wink will do! and probably cc some oracle devs right? There is something i want to try with workflow_dispatch in a testing repo. But as tom cruise would say: we need two miracles in succession. First the manual dispatch would have to actually appear under the PR if its even possible to run them on PR branches. Second: dispatch can use up to 10 input variables on its form, i could try to map them to labels somehow. I hope you can use them in job conditions since there are some things you can't use: e.g env vars for entirely undocumented reasons. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
