mbien commented on PR #4431: URL: https://github.com/apache/netbeans/pull/4431#issuecomment-1264147789
> One concern I have is, that the labels are not there, when a PR is created and would need a trigger. Forcing users/reviewers to do a forced push or request one sounds stupid and I remembered, that gitlab had an option to manually trigger CI/CD pipelines and it turns out github has something similar: > > https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch > > This would allow a reviewer add labels and then trigger a run. What do you think? thanks for taking a look @matthiasblaesing I can always count on you for reviews :) I fully agree that this is currently the most annoying aspect of this change, I haven't figured out how to solve this though. Here the issues: - if a workflow is manually triggered via `workflow_dispatch` it can't access the pr-context since there is none, it would simply run on a branch. So it would see no labels etc, it would also not show up below the PR as checkmark i am afraid (not tested but i can't see how it would) - there are various [other triggers](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#available-events) available. E.g it would be possible to trigger if someone adds or removes a label on the PR. but this would be overkill. Due to the limitations of the declarative yaml file I don't know how to trigger only on a certain label (I don't think its currently possible), it would run on every add or remove event. I haven't given up on that. Ideas welcome. We have still options though: - we could let unlabeled PRs run everything instead of the minimum job count, (`ci:all-tests` equivalent) would this be a better default? - or we could check if it is even a problem in practice: how often does it happen that a new contributor submits a perfect PR which would create the awkward situation of a reviewer having to label the PR and request a sync? - (I should probably also update the PR template text to mention that PRs should be labeled before pressing create) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
