mbien commented on PR #4431:
URL: https://github.com/apache/netbeans/pull/4431#issuecomment-1264779169
> > this would trigger a new run every time a label is added which is
probably too much since we have also the do-not-merge label etc
>
> Given this enables many of the tests to eventually not run without
required labels, I'm not sure that's a huge issue in practice, and it's
certainly more obvious. If the label trigger works, IMO we could also consider
going back to minimal tests by default from the start.
when I read the doc this indeed seemed to be the obvious way how to solve
this issue. But this dissipated quickly:
- labeled events are fired for each label. So if you put 3 labels on a pr
it will start 3 workflows + the open event which makes 4. We have the
concurrency rule which would shut down all workflows except the newest, but
this would still create a lot of noise on the /actions page
- we use do-not-merge/stale labels for meta-info. This can become a problem
when someone accidentally resets a build someone else is looking at
- when someone would bulk label a bunch of PRs at once via the /pulls page
it would simply cause too much building at once IMO
how about using the `unlocked` event as "secret" trigger for the workflow? I
just tested it in a sandbox and it worked well
- I don't think it sends mails (I am not sure, difficult to test with just
one account, in fact, let me test this by locking this PR, you can tell me if
you got a mail :)), close/reopen does
- it is less invasive than 'reopened'
- maybe one day gh will support better ways of doing this. e.g via adding a
custom button to the checks or restarting workflows with a fresh context
optionally
I assume that most devs will try to label PRs correctly right away or will
sync PRs several times anyway during review which gives enough opportunities to
update labels. For new contributors and the event of a PR which does not need
any changes, reviewers could use this semi-secret trick to trigger a new build
after labeling the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
