javierllorente commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1017129914
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
Review Comment:
OK, so that line should be written on demand (JDK vs no JDK shipped).
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
+Recommends: ${RPM_RECOMMENDS}
+AutoReqProv: no
+
+%description
+${RPM_DESCRIPTION}
+
+%files
+%{_bindir}/netbeans
Review Comment:
%{name} resolves to apache-netbeans. That's why I setted it to netbeans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
