neilcsmith-net commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1018109283
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
Review Comment:
I assume Recommends works similarly to DEB, in that packaging tools will
usually prompt to install, but it can be installed without error if someone did
want to use a JDK they'd installed in some other fashion?
If the runtime is bundled, then there is no need for the JDK at all. That's
why it's only added in the DEB when no JDK is included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
