neilcsmith-net commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1018120364
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
+Recommends: ${RPM_RECOMMENDS}
+AutoReqProv: no
+
+%description
+${RPM_DESCRIPTION}
+
+%files
+%{_bindir}/netbeans
Review Comment:
I understand why `%{name}` can't be used, but the binary launcher will not
be called `netbeans` if packaging an rcp application. If you need the name of
the launcher and it cannot just be `%{_bindir}/*`then pass in the value of
`execName` into `setupSpecFile()` and use a token.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
