errael commented on PR #5309:
URL: https://github.com/apache/netbeans/pull/5309#issuecomment-1416877254

   > please revert all changes to empty set and singleton sets. One is 
immutable the other is not.
   
   @mbien @tbw777 I don't know git/github that well (I use mercurial) Is there 
a way to remove/revert the last change, rather than add/force another change on 
top of that? If another change is added on top of the last one, it seems 
difficult to know that all the empty/singleton changes are removed. 
   
   If the last change is removed, then the relatively small cleanup change 
could be added.
   
   Side question. There seems to be at least two method to evolving PRs. 
   
   1. Multiple commits with squash when merged
   2. Use force and keep it a single commit
   
   Is 1. easier to work with (considering the current situation). They should 
give the same result, right? 
   
   Does NetBeans have guidance about this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to