mbien commented on PR #5309: URL: https://github.com/apache/netbeans/pull/5309#issuecomment-1416879538
> Side question. There seems to be at least two method to evolving PRs. > > 1. Multiple commits with squash when merged we don't let gh squash third party PRs since gh does sometimes weird things with author information which depends how the account is set up. PRs like this one here are merged as is - so the final commits are important and they are also checked via the peperwork job. > > 2. Use force and keep it a single commit there is no rule. Not all PRs will be a single commit after merge. Some are better to be merged as multiple commits. Esp if the author does a bugfix + refactoring. Those have to be kept separate. whatever makes it easier, there is no rule as long individual commits are buildable and green - otherwise this will cause trouble on git bisect. This PR here was basically ready and only needed the fix for copyOf. I don't understand what is going on now tbh but I have no time to review it anyway atm. This will need a full review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
