neilcsmith-net commented on PR #5309: URL: https://github.com/apache/netbeans/pull/5309#issuecomment-1416881165
> Side question. There seems to be at least two method to evolving PRs. > > 1. Multiple commits with squash when merged > 2. Use force and keep it a single commit > > Is 1. easier to work with (considering the current situation). They should give the same result, right? @errael side answer 😄 please don't squash and merge. Both GitHub UI and CLI have (different) negative side effects there. Do agree that multiple commits can be better when kept during reviews though. PR branches are generally writable by committers as well as authors, so squashing and force pushing into the PR branch for final checks before merging is ideal IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
