mbien commented on PR #5970: URL: https://github.com/apache/netbeans/pull/5970#issuecomment-1556013329
> What do you think about having a test validating that the Bundle.properties contains everything of the enum. With your approach we still cannot ensure that somebody will use an incorrect naming, when we have a test we can ensure that and prevent nothing being rendered because of an Exception. the annotations generate a bundle at build time. Such consistency test could be still useful if you want to add one. Having the default property values directly above the enum makes later updates which add more enum values straight forward since everything is in one place. I wouldn't go crazy on validation here since this PR makes future updates already much easier and therefore less error prone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
