mbien commented on PR #5970:
URL: https://github.com/apache/netbeans/pull/5970#issuecomment-1556018974

   > > to fix the tests we have to make two more changes: 
`JAKARTA_EE_10_WEB("10", "web"),` + `JAKARTA_EE_10_FULL("10");`
   > > have have to change `"10"` to `"10.0"`
   > 
   > Is that profile information stored somewhere? Are you sure there are no 
side effets when we change from `10` to `10.0`. Just to ensure existing 
projects already using Jakarta EE 10 will get in trouble.
   
   no I am not sure, that is something I have to check before we merge. This 
would be a problem in any case since the tests already failed even without this 
PR applied (they expect `10.0`). I opted for consistency for now - which means 
it is `10.0` because everything else had a `.0` too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to