asbachb commented on PR #5970: URL: https://github.com/apache/netbeans/pull/5970#issuecomment-1556022811
> > What do you think about having a test validating that the Bundle.properties contains everything of the enum. With your approach we still cannot ensure that somebody will use an incorrect naming, when we have a test we can ensure that and prevent nothing being rendered because of an Exception. > > the annotations generate a bundle at build time. Having the default property values directly above the enum makes later updates which add more enum values straight forward since everything is in one place. > > I wouldn't go crazy with validation here since this PR makes future updates already much easier and therefore less error prone. Didn't realized you already responded :D Actually prior this PR I already experimented with moving out the UI stuff out of that class as from my understanding it's most likely used for backend related stuff. I just reverted it as it results into an API breakage and several other classes needed to be touched. From my experience mixing both can get you in messy situations - Maybe in this case it's a little bit too much, but I wonder if this class should contain any UI related stuff (like the `Comparator` or the logic what the UI names should be) at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
