lahodaj commented on code in PR #6329:
URL: https://github.com/apache/netbeans/pull/6329#discussion_r1409097332
##########
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java:
##########
@@ -315,7 +316,10 @@ public void indexingComplete(Set<URL> indexedRoots) {
delegates = this.delegates.toArray(new
TextDocumentServiceImpl[this.delegates.size()]);
}
for (TextDocumentServiceImpl delegate : delegates) {
- delegate.reRunDiagnostics();
+ ProxyLookup augmentedLookup = new
ProxyLookup(Lookups.fixed(delegate.client), Lookup.getDefault());
+ Lookups.executeWith(augmentedLookup, () -> {
Review Comment:
Please note this runs outside of the event loop, this runs when indexing
finishes in a background thread, so the client is not set.
Note this also relates to what settings are used during indexing - there are
merged settings across all clients for used by the indexing (see
`SingleFileOptionsQueryImpl.globalOptions`), but for the editor, we can use the
sharper per-client settings.
##########
java/java.lsp.server/vscode/src/nbcode.ts:
##########
@@ -75,7 +75,7 @@ export function launch(
}
ideArgs.push(...extraArgs);
- if (env['netbeans_debug'] && extraArgs && extraArgs.find(s =>
s.includes("--list"))) {
+ if (extraArgs && extraArgs.find(s => s.includes("--list"))) {
Review Comment:
Oops, this is a mistake, will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
