lahodaj commented on code in PR #6329:
URL: https://github.com/apache/netbeans/pull/6329#discussion_r1409302767


##########
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java:
##########
@@ -315,7 +316,10 @@ public void indexingComplete(Set<URL> indexedRoots) {
                 delegates = this.delegates.toArray(new 
TextDocumentServiceImpl[this.delegates.size()]);
             }
             for (TextDocumentServiceImpl delegate : delegates) {
-                delegate.reRunDiagnostics();
+                ProxyLookup augmentedLookup = new 
ProxyLookup(Lookups.fixed(delegate.client), Lookup.getDefault());
+                Lookups.executeWith(augmentedLookup, () -> {

Review Comment:
   Ah, sorry, I misunderstood this to say this code is not needed. I suspect we 
don't have a meaningful `OperationContext` (as this runs asynchronously, and we 
probably should report any progress here anyway). Is there a way to get the 
`sessionLookup`? I don't think it is strictly necessary, but we could include 
that, in case it would be useful later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to