sdedic commented on code in PR #6329:
URL: https://github.com/apache/netbeans/pull/6329#discussion_r1409242306
##########
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java:
##########
@@ -315,7 +316,10 @@ public void indexingComplete(Set<URL> indexedRoots) {
delegates = this.delegates.toArray(new
TextDocumentServiceImpl[this.delegates.size()]);
}
for (TextDocumentServiceImpl delegate : delegates) {
- delegate.reRunDiagnostics();
+ ProxyLookup augmentedLookup = new
ProxyLookup(Lookups.fixed(delegate.client), Lookup.getDefault());
+ Lookups.executeWith(augmentedLookup, () -> {
Review Comment:
Understood. My point was that this wrapper sets up "client" (remembered in
the past) for the given TextDocumentServiceImpl instance; so eventually a
server > client notification/request finds its target. But an eventual Progress
API call made during the TextDocumentService processing (that assumes
OperationContext) will not find its per-client data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
