jtulach commented on PR #7059: URL: https://github.com/apache/netbeans/pull/7059#issuecomment-1941463459
> I am more than little nervous about introducing all FileObject's Lookup's contents - that is all services provided by the FO (editor, ...) into the (temporary) default Lookup (`Lookups.executeWith()`). These services are available anyway. One just needs to `obj.lookup(FileObject.class).getLookup().lookup(TheService.class)`. I just find code that [obtains file object lookup and seeks for DataObject](https://github.com/enso-org/enso/pull/9041/files#diff-7b3dd72d7026cb43b861131392237e427c6d14851f8d7ac708e83a18f7c3a855L149) obscure. Certainly it is not the way I intended the `FileObject.getLookup()` to be - it was supposed to provide all services representing the _selected file object_. Of course, should there be any performance consequences, I can write the longer complex lookup code. However I doubt there is any performance slowdown. The selected FileObject is probably opened in VSCode editor anyway... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
