jtulach commented on code in PR #7059: URL: https://github.com/apache/netbeans/pull/7059#discussion_r1492697011
########## java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/debugging/launch/NbLaunchDelegateTest.java: ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.java.lsp.server.debugging.launch; + +import java.io.File; +import java.io.IOException; +import java.util.Collection; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import java.util.function.Consumer; +import org.junit.After; +import org.junit.AfterClass; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; +import static org.junit.Assert.*; +import org.netbeans.api.project.Project; +import org.netbeans.api.project.ProjectManager; +import org.netbeans.modules.java.lsp.server.debugging.DebugAdapterContext; +import org.netbeans.spi.project.ActionProvider; +import org.netbeans.spi.project.ProjectFactory; +import org.netbeans.spi.project.ProjectState; +import org.netbeans.spi.project.SingleMethod; +import org.openide.filesystems.FileObject; +import org.openide.filesystems.FileUtil; +import org.openide.loaders.DataObject; +import org.openide.util.Lookup; +import org.openide.util.Pair; +import org.openide.util.lookup.Lookups; +import org.openide.util.lookup.ServiceProvider; + +public class NbLaunchDelegateTest { + + public NbLaunchDelegateTest() { + } + + @Test + public void testFileObjectsLookup() throws Exception { + FileObject fo = FileUtil.createMemoryFileSystem().getRoot().createData("test.txt"); + Lookup lkp = NbLaunchDelegate.createTargetLookup(null, null, fo); + assertEquals(fo, lkp.lookup(FileObject.class)); + + DataObject obj = lkp.lookup(DataObject.class); + assertNotNull("DataObject also found", obj); + + assertEquals("It's FileObject's data object", obj, DataObject.find(fo)); + assertNull("No single method", lkp.lookup(SingleMethod.class)); + } + + @Test + public void testFileObjectsLookupWithSingleMethod() throws Exception { + FileObject fo = FileUtil.createMemoryFileSystem().getRoot().createData("test-with-method.txt"); + SingleMethod m = new SingleMethod(fo, "main"); + Lookup lkp = NbLaunchDelegate.createTargetLookup(null, m, fo); + assertEquals(fo, lkp.lookup(FileObject.class)); + + DataObject obj = lkp.lookup(DataObject.class); + assertNotNull("DataObject also found", obj); + + assertEquals("It's FileObject's data object", obj, DataObject.find(fo)); + + assertEquals("Found single method", m, lkp.lookup(SingleMethod.class)); + } + + @Test + public void testFindsMavenProject() throws Exception { + FileObject dir = FileUtil.createMemoryFileSystem().getRoot().createFolder("testprj"); + FileObject xml = dir.createData("build.xml"); + Project prj = ProjectManager.getDefault().findProject(dir); + assertNotNull("Project dir recognized", prj); + + SingleMethod m = new SingleMethod(xml, "main"); + Lookup lkp = NbLaunchDelegate.createTargetLookup(prj, null, null); + assertNull("No file object", lkp.lookup(FileObject.class)); + DataObject obj = lkp.lookup(DataObject.class); + assertNull("No DataObject ", obj); + assertNull("No single method", lkp.lookup(SingleMethod.class)); + assertEquals(prj, lkp.lookup(Project.class)); + } + + @Test + public void testFindsWithFileObjectAndDataObject() throws Exception { + FileObject dir = FileUtil.createMemoryFileSystem().getRoot().createFolder("testprj"); + FileObject xml = dir.createData("build.xml"); + Project prj = ProjectManager.getDefault().findProject(dir); + assertNotNull("Project dir recognized", prj); + + SingleMethod m = new SingleMethod(xml, "main"); + Lookup lkp = NbLaunchDelegate.createTargetLookup(prj, m, xml); + assertEquals("File object is available", xml, lkp.lookup(FileObject.class)); + DataObject obj = lkp.lookup(DataObject.class); + assertNotNull("DataObject is available", obj); + assertEquals("DataObject's FileObject is correct", xml, obj.getPrimaryFile()); + assertEquals("Single method is also present", m, lkp.lookup(SingleMethod.class)); + assertEquals(prj, lkp.lookup(Project.class)); + } + + @Test + public void testAvoidNPEWithoutActionsProviderInLookup() throws Exception { + MockProjectFactory.MockProject prj = new MockProjectFactory.MockProject(FileUtil.getConfigRoot()); + Collection<ActionProvider> all = NbLaunchDelegate.findActionProviders(prj); + assertFalse("There shall be no null in " + all, all.contains(null)); + } + + @ServiceProvider(service = ProjectFactory.class) + public static final class MockProjectFactory implements ProjectFactory { + + @Override + public boolean isProject(FileObject projectDirectory) { + return projectDirectory.getNameExt().equals("testprj"); + } + + @Override + public Project loadProject(FileObject projectDirectory, ProjectState state) throws IOException { + return new MockProject(projectDirectory); Review Comment: Both LSP tests as well as VSCode extension tests are green. Thank you once again! - https://github.com/apache/netbeans/actions/runs/7933023631/job/21661225790?pr=7059 - https://github.com/apache/netbeans/actions/runs/7933023631/job/21661225230?pr=7059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
