jtulach commented on PR #7059:
URL: https://github.com/apache/netbeans/pull/7059#issuecomment-1948740472
> made only to the Lookup used for `isActionEnabled` ("test Lookup"),
> but not to the Lookup used for `invokeAction` ("invoke Lookup")
I am pretty sure the `createTargetLookup` is used for both. Otherwise, as
you point out, it would make no sense. Btw. the [ActionProvider in question is
here](https://github.com/enso-org/enso/pull/9041/files).
> * Project Lookups are not (AFAIK) required to contain the reference to the
Project (so this is potentially a breaking change),
I thought they are required to contain `this`. I can make sure to add
`Lookups.fixed(prj)` if `prj.getLookup().lookup(Project.class) != prj` - if you
want.
> * adding the whole `FileObject.getLookup()` - but I understand this may
match the usual content of the Lookup when running inside the whole NetBeans
GUI, so this is not a huge concern.
I hope it matches the original spirit more. On the other hand I admit I was
ready to remove the change, if it was the reason why the tests were failing
(but it wasn't).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
