matthiasblaesing commented on PR #7171: URL: https://github.com/apache/netbeans/pull/7171#issuecomment-2005006611
Only eyeballed this, but the decoupling looks like what I had in mind. This approach is more focused than what I thought about, but also looks sane. I noticed that you invented your own stringification algorithm for the keystrokes. I assume, that you don't use `Utilities.keyToString` directly because you don't agree with the stringification it creates? A question that came to my mind: how does the list react when it becomes to large for the window? Reason could be because the user resized it so small or because the list is just long. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
