neilcsmith-net commented on PR #7171:
URL: https://github.com/apache/netbeans/pull/7171#issuecomment-2006609205
> Only eyeballed this, but the decoupling looks like what I had in mind.
This approach is more focused than what I thought about, but also looks sane.
Thanks. I realised if we went for registering background components, we'd
still need to also register the actions for that component somewhere. There
are benefits to having action display directly in the module, but that doesn't
mean we couldn't extend to support other components later too.
> I noticed that you invented your own stringification algorithm for the
keystrokes. I assume, that you don't use `Utilities.keyToString` directly
because you don't agree with the stringification it creates?
Actually I copied that from KeyStrokeUtils in options.keymap (as commented).
`Utilities::keyToString` isn't really user friendly for this - eg. `DS-O` vs
`Ctrl+Shift+O`. I was thinking that we needed a utility API that provides the
text you'd see in the menu, etc. Just having another look, I realised that's
already available in `Actions::keyStrokeToString`. I've updated the PR to use
that instead.
> A question that came to my mind: how does the list react when it becomes
to large for the window? Reason could be because the user resized it so small
or because the list is just long.
The image disappears first, then the list will just get hidden. I thought
about limiting the number of actions, but I'm not sure that's needed as and
until we provide a UI to customise. The window needs to be small enough to be
unusable for the six registered here not to be in view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
