matthiasblaesing commented on code in PR #7117:
URL: https://github.com/apache/netbeans/pull/7117#discussion_r1536021017
##########
enterprise/web.jsf20/nbproject/project.properties:
##########
@@ -20,3 +20,5 @@ javac.source=1.8
release.external/javax.faces-2.3.9.jar=modules/ext/jsf-2_2/javax.faces.jar
release.external/javax.faces-2.3.9-license.txt=modules/ext/jsf-2_2/license.txt
spec.version.base=1.57.0
+
+sigtest.public.packages=javax.faces,com.sun.faces
Review Comment:
I think you are looking for
`sigtest.public.packages=javax.faces.**,com.sun.faces.**` (the API is declared
base on the `subpackages` element).
This needs a deeper look. For example Groovy is being looked for because
there is `com.sun.faces.scripting.groovy.GroovyHelperImpl`. The API declaration
of this module is ugly/lazy/wrong.
##########
java/j2ee.eclipselink/nbproject/project.properties:
##########
@@ -38,3 +38,5 @@
release.external/jakarta.persistence-2.2.3.jar=modules/ext/eclipselink/jakarta.p
release.build/jakarta.persistence-2.2.3-doc.zip=modules/ext/docs/jakarta.persistence-2.2.3-doc.zip
extra.module.files=modules/ext/docs/jakarta.persistence-2.2.3-doc.zip
+
+sigtest.public.packages=org.eclipse,javax.persistence
Review Comment:
Strange error here when generating signature file.
##########
enterprise/j2eeapis/nbproject/project.properties:
##########
@@ -17,3 +17,5 @@
is.autoload=true
release.external/deployment-api-1.2-rev-1.jar=modules/ext/jsr88javax.jar
+
+sigtest.public.packages=javax.enterprise.deploy
Review Comment:
This is wrong/not needed. The declared API does not match this. Have a look
at the project properties, API versioning, public packages list. All packages
are marked exported. The new behavior to cover these is right in that regard.
Given the broken before state, I would regenerate the sigfile here.
##########
platform/libs.osgi/nbproject/project.properties:
##########
@@ -20,3 +20,5 @@ javac.compilerargs=-Xlint -Xlint:-serial
release.external/osgi.core-8.0.0.jar=modules/ext/osgi.core-8.0.0.jar
release.external/osgi.cmpn-7.0.0.jar=modules/ext/osgi.cmpn-7.0.0.jar
+
+sigtest.public.packages=org.osgi,info.dmtree
Review Comment:
Same reasoning as `libs.gradle`. The approach might work for OSGI if all
packages would be listed here and only packages with problematic references are
excluded and commented acordingly.
##########
enterprise/web.jsf12/nbproject/project.properties:
##########
@@ -17,3 +17,5 @@
release.external/jsf-api-1.2_05.jar=modules/ext/jsf-1_2/jsf-api.jar
spec.version.base=1.48.0
+
+sigtest.public.packages=javax.faces
Review Comment:
This does not seem necessary. The missing dependency reported by the
sigcheck is present:
```diff
# This patch file was generated by NetBeans IDE
# It uses platform neutral UTF-8 encoding and \n newlines.
--- a/enterprise/web.jsf12/nbproject/project.xml
+++ b/enterprise/web.jsf12/nbproject/project.xml
@@ -26,6 +26,13 @@
<code-name-base>org.netbeans.modules.web.jsf12</code-name-base>
<module-dependencies>
<dependency>
+ <code-name-base>org.netbeans.libs.jstl</code-name-base>
+ <run-dependency>
+ <release-version>1</release-version>
+ <specification-version>2.58</specification-version>
+ </run-dependency>
+ </dependency>
+ <dependency>
<code-name-base>org.netbeans.modules.servletjspapi</code-name-base>
<build-prerequisite/>
<compile-dependency/>
```
With that the whole API will be captured in the sigfile (only had a quick
look at the resulting file, but first glance looked sane).
##########
extide/libs.gradle/nbproject/project.properties:
##########
@@ -21,5 +21,6 @@ javac.compilerargs=-Xlint -Xlint:-serial
# For more information, please see http://wiki.netbeans.org/SignatureTest
sigtest.gen.fail.on.error=false
+sigtest.public.packages=org.gradle
Review Comment:
This is wrong - and masks the real problem: sigtest fails to parse the class
files. IMHO we should in this case disable sigtest and not pretend it does
something sensible here. A comment documenting the problem might help future
readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
