matthiasblaesing commented on code in PR #7117:
URL: https://github.com/apache/netbeans/pull/7117#discussion_r1536671847
##########
ide/libs.lucene/nbproject/project.properties:
##########
@@ -19,3 +19,8 @@ is.autoload=true
javac.source=1.8
javac.compilerargs=-Xlint -Xlint:-serial
release.external/lucene-core-3.6.2.jar=modules/ext/lucene-core-3.6.2.jar
+
+# This is an very old library, the complete dependencies were never explored.
+# Since subpackage-s are working in new sigtest version, generation of the
+# signature file fails. Disabling that now.
Review Comment:
Disabling is fine, the comment though does not match the reason (from my
POV). The reported error is:
```
/home/matthias/src/netbeans/nbbuild/templates/projectized.xml:765:
java.lang.AssertionError:
org.apache.lucene.search.CachingWrapperFilter$FilterCache<org.apache.lucene.search.DocIdSet>
at
com.sun.tdk.signaturetest.loaders.BinaryClassDescrLoader.load(BinaryClassDescrLoader.java:225)
at
com.sun.tdk.signaturetest.core.ClassHierarchyImpl.load(ClassHierarchyImpl.java:180)
at
com.sun.tdk.signaturetest.core.ClassHierarchyImpl.getClassInfo(ClassHierarchyImpl.java:292)
at
com.sun.tdk.signaturetest.core.ClassHierarchyImpl.isInterface(ClassHierarchyImpl.java:272)
at
com.sun.tdk.signaturetest.core.ClassCorrector.fixType(ClassCorrector.java:315)
at
com.sun.tdk.signaturetest.core.ClassCorrector.fixMethods(ClassCorrector.java:298)
```
So I would say this is the same as in other cases: sigtest fails to parse
the API classes.
##########
ide/libs.flexmark/nbproject/project.properties:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-javac.source=1.8
+javac.source=11
Review Comment:
I think this can be reverted as only the sigtest is disabled.
##########
java/j2ee.eclipselink/nbproject/project.properties:
##########
@@ -38,3 +38,6 @@
release.external/jakarta.persistence-2.2.3.jar=modules/ext/eclipselink/jakarta.p
release.build/jakarta.persistence-2.2.3-doc.zip=modules/ext/docs/jakarta.persistence-2.2.3-doc.zip
extra.module.files=modules/ext/docs/jakarta.persistence-2.2.3-doc.zip
+
+# There are some unexplored dependencies (Java Mail, and JAX-RS API ?)
Review Comment:
```suggestion
# There are some missing dependencies (Java Mail, and JAX-RS API ?)
```
I'm wondering whether it would make sense to disable sigtest here as the API
definition is much to broad. ecpliselink has a huge set of `internal` packages,
which I would not consider API.
##########
enterprise/web.jsf20/nbproject/project.properties:
##########
@@ -20,3 +20,7 @@ javac.source=1.8
release.external/javax.faces-2.3.9.jar=modules/ext/jsf-2_2/javax.faces.jar
release.external/javax.faces-2.3.9-license.txt=modules/ext/jsf-2_2/license.txt
spec.version.base=1.57.0
+
+# Old library without fully explored dependencies better to disable sigtest
Review Comment:
```suggestion
# Old library with too broadly defined API - sigtest would give more noise
than benefit
# (legacy behavior of sigtest ignored subpackages)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
