matthiasblaesing commented on code in PR #7117: URL: https://github.com/apache/netbeans/pull/7117#discussion_r1536664968
########## enterprise/web.jsf12/nbproject/project.properties: ########## @@ -17,3 +17,5 @@ release.external/jsf-api-1.2_05.jar=modules/ext/jsf-1_2/jsf-api.jar spec.version.base=1.48.0 + +sigtest.public.packages=javax.faces Review Comment: Where? We build on JDK 11+ always and I tried setting `javac.source` and `javac.target` to `11` and `gen-sigtest` created an identical file (modulo expected changes because JDK package changed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
