vieiro commented on PR #7180: URL: https://github.com/apache/netbeans/pull/7180#issuecomment-2016879675
> There are a few places in the IDE where the ANTLR generated java files are in the codebase. These are not re-generated during build time. and would cause warnings on the output: > > ``` > ANTLR Tool version 4.11.1 used for code generation does not match the current runtime version 4.13.1 > ``` > > Fortunately it's nothing more serious than that this time. > > Affected languages, that I remember: ANTLR v3, ANTLR v4, Go, JSON, maybe CSS Good point! Anyway in order to avoid problems in the future these grammars should be rebuilt with the IDE's Antlr runtime, right? - `webcommon/javascript2json` [currently rebuilds the grammar](https://github.com/apache/netbeans/blob/a74ce3b45ce698269109b87c984ca6d8d96b4471/webcommon/javascript2.json/build.xml#L29) so we should be safe. - `ide/languages.toml` currently doesn't. - `ide/languages.go` [currently doesn't, there's no grammar there](https://github.com/apache/netbeans/blob/a74ce3b45ce698269109b87c984ca6d8d96b4471/ide/languages.go/build.xml#L27), so we can't regenerate the lexer/parser with new runtime. - `ide/lexer.antlr4` builds a grammar for testing purposes, but [there's no lexer/grammar for the Antlr4 lexer either](https://github.com/apache/netbeans/blob/a74ce3b45ce698269109b87c984ca6d8d96b4471/ide/lexer.antlr4/build.xml#L32) I think we should add the .g4 lexers and grammars to the source code, and rebuild them with IDE's runtime, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
