neilcsmith-net commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537347691
########## ide/libs.tomljava/manifest.mf: ########## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle: org/netbeans/libs/tomljava/Bundle.properties +OpenIDE-Module-Specification-Version: 1.0 Review Comment: OK, the test should be picking up a problem here as far as I can tell. I think it might have become too lenient! I think there's an issue stemming from #4775 where it's ignoring modules without a declared Java dependency, and I think also ignoring non-referenced autoloads. The test looks like it potentially needs `honorAutoloadEager` switched off, and to always add a default version for all module referenced JARs in https://github.com/apache/netbeans/blob/master/platform/o.n.core/test/qa-functional/src/org/netbeans/core/validation/ValidateClassFilesTest.java#L129 Interestingly, also noticed that there is code to add Java dependency automatically for value of `javac.target` that has a now incorrect regex protecting it?? https://github.com/apache/netbeans/blob/master/nbbuild/antsrc/org/netbeans/nbbuild/JarWithModuleAttributes.java#L221 (I was looking for where this dependency was being added automatically when I noticed the test now relies on its presence). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
