vieiro commented on code in PR #7180:
URL: https://github.com/apache/netbeans/pull/7180#discussion_r1536894486


##########
ide/libs.tomljava/manifest.mf:
##########
@@ -0,0 +1,4 @@
+Manifest-Version: 1.0
+OpenIDE-Module: org.netbeans.libs.tomljava/3
+OpenIDE-Module-Localizing-Bundle: org/netbeans/libs/tomljava/Bundle.properties
+OpenIDE-Module-Specification-Version: 1.0

Review Comment:
   antlr4-runtime-4.13.1 is still Java 8 (thought it was 11), toml-java is Java 
11.
   
   ```sh
   $ javap -v -cp antlr4-runtime-4.13.1.jar org.antlr.v4.runtime.CharStream
   Classfile 
jar:file:///[...]/netbeans/ide/libs.antlr4.runtime/external/antlr4-runtime-4.13.1.jar!/org/antlr/v4/runtime/CharStream.class
     Last modified 4 sept 2023; size 237 bytes
     SHA-256 checksum 
f56df94dc6d8100a59ee452da9e9cdd30b94523ce8e297daeab781193aed81c1
     Compiled from "CharStream.java"
   public interface org.antlr.v4.runtime.CharStream extends 
org.antlr.v4.runtime.IntStream
     minor version: 0
     major version: 52
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to