neilcsmith-net commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537849400
########## ide/libs.tomljava/manifest.mf: ########## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle: org/netbeans/libs/tomljava/Bundle.properties +OpenIDE-Module-Specification-Version: 1.0 Review Comment: I assumed from the conversation above that the built module manifest didn't have the version in it. Checking the dev build shows this attribute is included already. I misread the regexp as if using `+` rather than `*` because I thought it wasn't passing the if check. All in all a long way around to no change required here then? :smile: The test does still need looking at, but should be passing for the right reasons here. And, yes, explicitly added manifest fields should be redundant for cases where `javac.target` is set then. There are a few places this is used where this wasn't the case (eg. JShell support IIRC). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
