mbien commented on code in PR #7180: URL: https://github.com/apache/netbeans/pull/7180#discussion_r1537814701
########## ide/libs.tomljava/manifest.mf: ########## @@ -0,0 +1,4 @@ +Manifest-Version: 1.0 +OpenIDE-Module: org.netbeans.libs.tomljava/3 +OpenIDE-Module-Localizing-Bundle: org/netbeans/libs/tomljava/Bundle.properties +OpenIDE-Module-Specification-Version: 1.0 Review Comment: regarding JarWithModuleAttributes.java: we should check `javac.release` there too. However the regexp looks good to me, no? I didn't know that this existed - this essentially makes all the manually added manifest fields redundant, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
