lahodaj commented on code in PR #7248: URL: https://github.com/apache/netbeans/pull/7248#discussion_r1557001429
########## ide/libs.graalsdk/external/binaries-list: ########## @@ -14,5 +14,14 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -8E62643FD621053E00EE52D797C7FBD08D7FDEDC org.graalvm.sdk:graal-sdk:20.3.0 -8968BDBE4058F4E6610AF0DC184BD885B236A2B1 org.graalvm.sdk:launcher-common:20.3.0 +8AA4ECE060629AAAED57215A5FD8C377EFF1A191 org.graalvm.sdk:graal-sdk:24.0.0 Review Comment: Technically, `graal-sdk` may not be needed - it seems to be just a placeholder package, and the original packages probably have been split up into some of the other bundles here. As a side note, maybe there's a better name for the module? maybe `libs.graal`? ########## ide/libs.graalsdk/external/binaries-list: ########## @@ -14,5 +14,14 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -8E62643FD621053E00EE52D797C7FBD08D7FDEDC org.graalvm.sdk:graal-sdk:20.3.0 -8968BDBE4058F4E6610AF0DC184BD885B236A2B1 org.graalvm.sdk:launcher-common:20.3.0 +8AA4ECE060629AAAED57215A5FD8C377EFF1A191 org.graalvm.sdk:graal-sdk:24.0.0 +06055903437576484DCC6545AF995FF67E0A3B55 org.graalvm.sdk:launcher-common:24.0.0 +335646EC205A3BCE0D518748D08A5C45900A9869 org.graalvm.shadowed:jline:24.0.0 Review Comment: I guess the license file for JLine is not present (which may be reason why the paperwork job failed). (And I don't think pure UPL would be the correct license for that.) ########## webcommon/libs.graaljs/external/js-23.0.3-license.txt: ########## @@ -2,8 +2,8 @@ Name: Graal SDK and Truffle API Description: Graal SDK and Truffle API Review Comment: Nit: please rename the file to `...-24.0.0-...`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
