sdedic commented on code in PR #7248: URL: https://github.com/apache/netbeans/pull/7248#discussion_r1559527907
########## ide/libs.graalsdk/external/binaries-list: ########## @@ -14,5 +14,14 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -8E62643FD621053E00EE52D797C7FBD08D7FDEDC org.graalvm.sdk:graal-sdk:20.3.0 -8968BDBE4058F4E6610AF0DC184BD885B236A2B1 org.graalvm.sdk:launcher-common:20.3.0 +8AA4ECE060629AAAED57215A5FD8C377EFF1A191 org.graalvm.sdk:graal-sdk:24.0.0 Review Comment: I would prefer not to rename modules, unless necessary. We can have module_auto_deps entry, I'd stick with the current name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
